lib/llm/src/block_manager/connector/protocol.rs (1)

152-154: Confirm whether #[serde(default)] should mask missing block_ids.
Defaulting to empty accepts older senders but silently drops error tracking. If deployments are atomic and you want strictness, consider making the field required so deserialization fails fast when it’s absent.

💡 Possible tweak to keep the protocol explicit

-    #[serde(default)]
-    pub block_ids: Vec<usize>,
+    pub block_ids: Vec<usize>,

Based on learnings, keep the spec explicit if backward compatibility isn't required.

lib/bindings/kvbm/src/block_manager/vllm/connector/worker.rs (2)

128-129: Track the TODO with an issue (or handle in this PR).

Leaving the “move this out of bindings” TODO without tracking risks it lingering.

Do you want me to propose a follow-up issue or a concrete refactor plan?

---

136-137: Avoid silent truncation when casting block IDs to u32.

If block_id can exceed u32::MAX, as u32 will truncate. Consider try_from (or an assertion) to make this safe.

♻️ Safer conversion

-                        for &block_id in block_ids {
-                            self.failed_block_ids.insert(block_id as u32);
-                        }
+                        for &block_id in block_ids {
+                            match u32::try_from(block_id) {
+                                Ok(block_id_u32) => {
+                                    self.failed_block_ids.insert(block_id_u32);
+                                }
+                                Err(_) => {
+                                    tracing::warn!(
+                                        request_id = %request_id,
+                                        operation_id = %uuid,
+                                        block_id,
+                                        "block_id exceeds u32::MAX; skipping"
+                                    );
+                                }
+                            }
+                        }